-
Notifications
You must be signed in to change notification settings - Fork 852
fix: remove icon_url from url source block element and plan_id from plan block and update chat stream variable #1822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feat-ai-apps-thinking-steps
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat-ai-apps-thinking-steps #1822 +/- ##
==============================================================
Coverage ? 83.96%
==============================================================
Files ? 116
Lines ? 13221
Branches ? 0
==============================================================
Hits ? 11101
Misses ? 2120
Partials ? 0 ☔ View full report in Codecov by Sentry. |
srtaalej
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎆
| async def _flush_buffer(self, chunks: Optional[Sequence[Union[Dict, Chunk]]] = None, **kwargs) -> AsyncSlackResponse: | ||
| """Flush the internal buffer with chunks by making appropriate API calls.""" | ||
| flushings: List[Union[Dict, Chunk]] = [] | ||
| chunks_to_flush: List[Union[Dict, Chunk]] = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Summary
This PR removes the
icon_urlfrom theurlsource block element to match the expected API and also updates an internalchat_streamvariable for maintenance ongoing.The
plan_idis also removed from the plan block.Testing
Build these changes and stream a message with this app:
Category
/docs(Documents)tests/integration_tests(Automated tests for this library)Notes
No update was made for an
appendwithout either "chunks" or "markdown_text" following discussion of #1809. With logging set to "debug" we might find an alright hint that the buffer is unchanged:Requirements
python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.shafter making the changes.